-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/crit app frame #219
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd source component
…yle for ref and seg element
…inside analogues folder
…layouts when initialized
…te/analogue empty textContent
…component, rationalized collecting of sources and linked elements
…_rules Fix for editorial conventions
…rame # Conflicts: # src/app/services/editorial-conventions.service.ts
Replaced with PR #220 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch populated the three sections of the Apparatus-Sources-Analogues frame.
Parsing of sources and analogues attributes can be custumized in new keys inside edition_config.json.
The aspect of sources and analogues elements in the text flow can be configured in editorial_conventions_config.json.
Since sources and analogues refer to different markups, said customization will use the dot notation to clarify that we are styling a group of elements '.analogues' and '.sources', and not the single elements quote/cit/div/ref/seg/p/l... that can be recognized as such (example at the end of the post).
Default values for this editorial configuration joined the similar defaults inside editorial-conventions-service.ts.
The highlight color for click and hover events on the sources and analogues is taken from existing values edition.readingColorDark and edition.readingColorHight key in edition_config.json.
In order to apply them, this branch uses a new small function that can be extended in the future to load generic CSS written by the users.
Both analogue entry and source entry components use the existing evt-content-viewer component in order to display their nested elements both in the text flow and in their frame.
In the case of self-closed elements such as PTR or empty elements, the source or analogue element will be displayed as a note/exponent in the text flow.
New features:
Managing Sources and Analogues classes required setting up the parsing and models of various elements:
Added few utilities in dom-utils and xml-utils.
Changes to existing features:
Elements modified for @source (customizable in config) attribute recognition and relative elements retrieving:
Added correct type referral in MsDescParser for new BiblList, Bibl, and Quote types.
A json you may use to test editorial conventions for analogues and sources: